#3799 has a bug, so I fixed it up alongside simplifying the logic slightly and adding a config flag to opt in to this new behaviour.
Currently live on https://campfyre.nickwebster.dev
I was getting close to hitting the end of my free object storage so there was time pressure involved haha.
Seems to work but I haven't tested it too much. Currently running on my instance.
You're viewing a single thread.
21 comments
I think the local caching was intentional to reduce load on remote instances, should we disable it?
What I'd rather see is cleanup of cached data and more granular control of that cleanup, rather than completely disabling it.
Agreed, I sadly don't have the time to implement that.
Fair enough.
That's why I made it a config option that defaults to true (defaults to caching on).
I think big instances should cache, but for smaller instances with less funding and resources it makes sense to skip the caching.
This also helps mitigate the risk of people posting CSAM to attack other communities which your instance is subscribed to right? If you instance never cached the image, there's no clean-up you have to do on your end provided the original instance removes the image from their server.
As you've mentioned, it makes sense for larger instances to have a cache, but smaller instance (especially single-user instances) may actually be better off not caching at all and just hosting their own images. As a more long-term solution which can add to this patch, it would be good if Lemmy did 2 things:
Separated the image cache for images from other instances so it can be cleared automatically on a schedule. E.g. Images which are a local cache are deleted after X days. Yes there are proper caching algorithms used in filesystems which would be better long-term, but a quick solution for this is probably better than no solution.
Periodically check for images which were uploaded by your own users to see if they are being referenced by any posts or comments. If not, delete them. I would imagine this could be a fairly intense operation so limiting this more fine-grained approach to images uploaded by your own users and taking the more liberal approach with cached images may help performance.